Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22288#discussion_r227060905
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
    @@ -453,6 +504,25 @@ private[spark] class TaskSchedulerImpl(
         return tasks
       }
     
    +  private def createUnschedulableTaskSetAbortTimer(
    +      taskSet: TaskSetManager,
    +      taskIndex: Int,
    +      timeout: Long): TimerTask = {
    +    new TimerTask() {
    +      override def run() {
    +        if (unschedulableTaskSetToExpiryTime.contains(taskSet) &&
    +          unschedulableTaskSetToExpiryTime(taskSet) <= 
clock.getTimeMillis()
    +        ) {
    --- End diff --
    
    nit: I think the style is to double-indent the second line of the 
continuation, and close it at the end of that line
    
    ```scala
    if (unschedulableTaskSetToExpiryTime.contains(taskSet) &&
        unschedulableTaskSetToExpiryTime(taskSet) <= clock.getTimeMillis()) {
      logInfo
    ```


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to