GitHub user sel opened a pull request:
https://github.com/apache/spark/pull/22798
[SPARK-25803] Fix docker-image-tool.sh -n option
## What changes were proposed in this pull request?
docker-image-tool.sh uses getopts in which a colon signifies that an
option takes an argument. Since -n does not take an argument it
should not have a colon.
## How was this patch tested?
1. Built container images without '-n'
https://gist.github.com/sel/59f0911bb1a6a485c2487cf7ca770f9d
2. Built container images with '-n' to reproduce the issue
https://gist.github.com/sel/e5cabb9f3bdad5d087349e7fbed75141
3. Applied the patch and re-build container images with '-n' and did not
reproduce the issue
https://gist.github.com/sel/6af14b95012ba8ff267a4fce6e3bd3bf
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sel/spark fix-docker-image-tool-nocache
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22798.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22798
----
commit a07d105d27b7f73cf04af2c6711f8d64c3b5a843
Author: Steve <sel@...>
Date: 2018-10-22T21:17:10Z
[SPARK-25803] Fix docker-image-tool.sh -n option
docker-image-tool.sh uses getopts in which a colon signifies that an
option takes an argument. Since -n does not take an argument it
should not have a colon.
Signed-off-by: Steve <s...@users.noreply.github.com>
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
