Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22755#discussion_r227215773
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/joins/ExistenceJoinSuite.scala
---
@@ -122,19 +122,22 @@ class ExistenceJoinSuite extends SparkPlanTest with
SharedSQLContext {
test(s"$testName using BroadcastHashJoin") {
extractJoinParts().foreach { case (_, leftKeys, rightKeys,
boundCondition, _, _) =>
- withSQLConf(SQLConf.SHUFFLE_PARTITIONS.key -> "1") {
- checkAnswer2(leftRows, rightRows, (left: SparkPlan, right:
SparkPlan) =>
- EnsureRequirements(left.sqlContext.sessionState.conf).apply(
- BroadcastHashJoinExec(
- leftKeys, rightKeys, joinType, BuildRight, boundCondition,
left, right)),
- expectedAnswer,
- sortAnswers = true)
- checkAnswer2(leftRows, rightRows, (left: SparkPlan, right:
SparkPlan) =>
- EnsureRequirements(left.sqlContext.sessionState.conf).apply(
- createLeftSemiPlusJoin(BroadcastHashJoinExec(
- leftKeys, rightKeys, leftSemiPlus, BuildRight,
boundCondition, left, right))),
- expectedAnswer,
- sortAnswers = true)
+ Seq("false", "true").foreach { v =>
--- End diff --
nit: v -> codegenEnabled
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
