Github user rezasafi commented on a diff in the pull request:
https://github.com/apache/spark/pull/22612#discussion_r227222241
--- Diff:
core/src/main/scala/org/apache/spark/metrics/ExecutorMetricType.scala ---
@@ -95,10 +135,29 @@ private[spark] object ExecutorMetricType {
OnHeapUnifiedMemory,
OffHeapUnifiedMemory,
DirectPoolMemory,
- MappedPoolMemory
+ MappedPoolMemory,
+ ProcessTreeMetrics
+ )
+ // List of defined metrics
+ val definedMetrics = IndexedSeq(
+ "JVMHeapMemory",
+ "JVMOffHeapMemory",
+ "OnHeapExecutionMemory",
+ "OffHeapExecutionMemory",
+ "OnHeapStorageMemory",
+ "OffHeapStorageMemory",
+ "OnHeapUnifiedMemory",
+ "OffHeapUnifiedMemory",
+ "DirectPoolMemory",
+ "MappedPoolMemory",
+ "ProcessTreeJVMVMemory",
+ "ProcessTreeJVMRSSMemory",
+ "ProcessTreePythonVMemory",
+ "ProcessTreePythonRSSMemory",
+ "ProcessTreeOtherVMemory",
+ "ProcessTreeOtherRSSMemory"
--- End diff --
I changed this in a way similar to what you suggested to avoid having
separate names and also using arrays instead of maps
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
