Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22805#discussion_r227429795
  
    --- Diff: 
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/backend/IntegrationTestBackend.scala
 ---
    @@ -30,14 +30,16 @@ private[spark] trait IntegrationTestBackend {
     private[spark] object IntegrationTestBackendFactory {
       val deployModeConfigKey = "spark.kubernetes.test.deployMode"
     
    +  val backendMinikube = "minikube"
    --- End diff --
    
    Nit: should these be private?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to