Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22801#discussion_r227466613
  
    --- Diff: examples/src/main/python/sql/datasource.py ---
    @@ -57,6 +57,15 @@ def basic_datasource_example(spark):
                              format="csv", sep=":", inferSchema="true", 
header="true")
         # $example off:manual_load_options_csv$
     
    +    # $example on:manual_save_options_orc$
    +    df = spark.read.orc("examples/src/main/resources/users.orc")
    +    (df.write.format("orc")
    +        .option("orc.bloom.filter.columns", "favorite_color")
    +        .option("orc.dictionary.key.threshold", "1.0")
    +        .option("orc.column.encoding.direct", 'name')
    --- End diff --
    
    use same quote? `"` or `'` for name?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to