Github user pgandhi999 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21688#discussion_r227515191
  
    --- Diff: core/src/main/resources/org/apache/spark/ui/static/stagepage.js 
---
    @@ -52,22 +52,20 @@ $.extend( $.fn.dataTable.ext.type.order, {
     function stageEndPoint(appId) {
         var urlRegex = 
/https\:\/\/[^\/]+\/([^\/]+)\/([^\/]+)\/([^\/]+)?\/?([^\/]+)?\/?([^\/]+)?\/?([^\/]+)?/gm;
         var urlArray = urlRegex.exec(document.baseURI);
    -    var ind = urlArray.indexOf("proxy");
    +    var indexOfProxy = urlArray.indexOf("proxy");
         var queryString = document.baseURI.split('?');
         var words = document.baseURI.split('/');
         var stageId = queryString[1].split("&").filter(word => 
word.includes("id="))[0].split("=")[1];
    -    if (ind > 0) {
    +    if (indexOfProxy > 0) {
             var appId = urlArray[2];
    -        var indexOfProxy = words.indexOf("proxy");
    -        var newBaseURI = words.slice(0, indexOfProxy + 2).join('/');
    +        var newBaseURI = words.slice(0, words.indexOf("proxy") + 
2).join('/');
             return newBaseURI + "/api/v1/applications/" + appId + "/stages/" + 
stageId;
         }
    -    ind = urlArray.indexOf("history");
    -    if (ind > 0) {
    +    var indexOfHistory = urlArray.indexOf("history");
    +    if (indexOfHistory > 0) {
             var appId = urlArray[2];
    -        var appAttemptId = urlArray[ind + 2];
    -        var indexOfHistory = words.indexOf("history");
    -        var newBaseURI = words.slice(0, indexOfHistory).join('/');
    +        var appAttemptId = urlArray[indexOfHistory + 2];
    --- End diff --
    
    Done


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to