Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22755
It looks good to improve the test coverage. But, it seems to be hard to
wrap all the test case with `withSQLConf`. So, how about adding a helper
function for turning off/on codegen (`WHOLESTAGE_CODEGEN_ENABLED` and
`CODEGEN_FACTORY_MODE`) like `testBothCodegenAndInterpreted`? @cloud-fan
@gatorsmile
https://github.com/apache/spark/blob/584e767d372d41071c3436f9ad4bf77a820f12b4/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/UnsafeRowConverterSuite.scala#L38
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
