Github user gengliangwang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22814#discussion_r227755767
  
    --- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
 ---
    @@ -60,9 +60,11 @@ trait ExpressionEvalHelper extends 
GeneratorDrivenPropertyChecks with PlanTestBa
         def expr = prepareEvaluation(expression)
         val catalystValue = CatalystTypeConverters.convertToCatalyst(expected)
         checkEvaluationWithoutCodegen(expr, catalystValue, inputRow)
    -    checkEvaluationWithMutableProjection(expr, catalystValue, inputRow)
    -    if (GenerateUnsafeProjection.canSupport(expr.dataType)) {
    -      checkEvaluationWithUnsafeProjection(expr, catalystValue, inputRow)
    +    if (expected != null) {
    --- End diff --
    
    Need to figure out why the unsafe project failed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to