Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22820#discussion_r228030940
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/MountVolumesFeatureStep.scala
---
@@ -56,8 +56,10 @@ private[spark] class MountVolumesFeatureStep(
val volumeBuilder = spec.volumeConf match {
case KubernetesHostPathVolumeConf(hostPath) =>
+ // TODO: Backwards compatibility allows for empty string, but
specify
+ // hostPath type here
new VolumeBuilder()
- .withHostPath(new HostPathVolumeSource(hostPath))
+ .withHostPath(new HostPathVolumeSource(hostPath, ""))
--- End diff --
Can you add a short descriptive comment after the empty string, e.g., `/*
... */` to explain what the second argument is?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
