Github user erikerlandson commented on a diff in the pull request:
https://github.com/apache/spark/pull/22820#discussion_r228321586
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesUtils.scala
---
@@ -157,7 +157,10 @@ private[spark] object KubernetesUtils {
}.getOrElse(Seq(("container state", "N/A")))
}
- def formatTime(time: Time): String = {
- if (time != null) time.getTime else "N/A"
+ def formatTime(time: String): String = {
--- End diff --
I would keep it, but possibly add a comment about data type change
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
