Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22838#discussion_r228363727
--- Diff:
resource-managers/kubernetes/integration-tests/dev/dev-run-integration-tests.sh
---
@@ -103,4 +104,4 @@ then
properties=( ${properties[@]} -Dtest.exclude.tags=$EXCLUDE_TAGS )
fi
-$TEST_ROOT_DIR/build/mvn integration-test -f $TEST_ROOT_DIR/pom.xml -pl
resource-managers/kubernetes/integration-tests -am -Pkubernetes ${properties[@]}
+$TEST_ROOT_DIR/build/mvn integration-test -f $TEST_ROOT_DIR/pom.xml -pl
resource-managers/kubernetes/integration-tests -am -Pscala-$SCALA_VERSION
-Pkubernetes-integration-tests ${properties[@]}
--- End diff --
@skonto don't you need `-Pkubernetes` here too?
Otherwise, I don't even think we need to wait for another test. The exact
POM change above just passed in the other PR and this part won't be tested
anyway. I tested the SCALA_VERSION evaluation manually and it works.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
