Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22775#discussion_r228389610
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
---
@@ -770,8 +776,17 @@ case class SchemaOfJson(
factory
}
- override def convert(v: UTF8String): UTF8String = {
- val dt =
Utils.tryWithResource(CreateJacksonParser.utf8String(jsonFactory, v)) { parser
=>
+ @transient
+ private lazy val json = child.eval().asInstanceOf[UTF8String]
+
+ override def checkInputDataTypes(): TypeCheckResult = child match {
+ case Literal(s, StringType) if s != null => super.checkInputDataTypes()
+ case _ => TypeCheckResult.TypeCheckFailure(
+ s"The input json should be a string literal and not null; however,
got ${child.sql}.")
+ }
+
+ override def eval(v: InternalRow = EmptyRow): Any = {
--- End diff --
when implementing `eval`, we usually don't put the default value. Shall we
follow this code style?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
