Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22784#discussion_r228724541
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/RowMatrix.scala 
---
    @@ -384,18 +384,28 @@ class RowMatrix @Since("1.0.0") (
         val n = numCols().toInt
         require(k > 0 && k <= n, s"k = $k out of range (0, n = $n]")
     
    -    val Cov = computeCovariance().asBreeze.asInstanceOf[BDM[Double]]
    +    if (n > 65535) {
    +      val svd = computeSVD(k)
    +      val s = svd.s.toArray.map(eigValue => eigValue * eigValue / (n - 1))
    --- End diff --
    
    Right, make sense.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to