Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22857#discussion_r228760320
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -83,6 +83,7 @@ abstract class Optimizer(sessionCatalog: SessionCatalog)
BooleanSimplification,
SimplifyConditionals,
RemoveDispensableExpressions,
+ ReplaceNullWithFalse,
--- End diff --
Logically, `ReplaceNullWithFalse` can use the result of
`SimplifyBinaryComparison`. How about postponing this after
`SimplifyBinaryComparison`? In other words, switch `ReplaceNullWithFalse` and
`SimplifyBinaryComparison`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
