Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22844#discussion_r229019783
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonBenchmarks.scala
 ---
    @@ -195,23 +170,16 @@ object JSONBenchmarks extends SQLHelper {
             ds.count()
           }
     
    -      /*
    -      Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz
    -
    -      Count a dataset with 10 columns:      Best/Avg Time(ms)    Rate(M/s) 
  Per Row(ns)   Relative
    -      
---------------------------------------------------------------------------------------------
    -      Select 10 columns + count()               9961 / 10006          1.0  
       996.1       1.0X
    -      Select 1 column + count()                  8355 / 8470          1.2  
       835.5       1.2X
    -      count()                                    2104 / 2156          4.8  
       210.4       4.7X
    -      */
           benchmark.run()
         }
       }
     
    -  def main(args: Array[String]): Unit = {
    -    schemaInferring(100 * 1000 * 1000)
    -    perlineParsing(100 * 1000 * 1000)
    -    perlineParsingOfWideColumn(10 * 1000 * 1000)
    -    countBenchmark(10 * 1000 * 1000)
    +  override def runBenchmarkSuite(): Unit = {
    --- End diff --
    
    +1 for @yucai 's comment.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to