GitHub user ueshin opened a pull request: https://github.com/apache/spark/pull/22892
[SPARK-25884][SQL] Add TBLPROPERTIES and COMMENT, and use LOCATION when SHOW CREATE TABLE. ## What changes were proposed in this pull request? When `SHOW CREATE TABLE` for Datasource tables, we are missing `TBLPROPERTIES` and `COMMENT`, and we should use `LOCATION` instead of path in `OPTION`. ## How was this patch tested? Splitted `ShowCreateTableSuite` to confirm to work with both `InMemoryCatalog` and `HiveExternalCatalog`, and added some tests. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ueshin/apache-spark issues/SPARK-25884/show_create_table Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/22892.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #22892 ---- commit 2ca37061c37edb400c5779009c86abfb492032ac Author: Takuya UESHIN <ueshin@...> Date: 2018-10-30T06:33:46Z Split ShowCreateTableSuite. commit c2dce69370415f64c4ed802e5bdc241f1c868596 Author: Takuya UESHIN <ueshin@...> Date: 2018-10-30T09:55:06Z Add TBLPROPERTIES and COMMENT, and use LOCATION. ---- --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org