Github user xuanyuanking commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22878#discussion_r229770190
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
 ---
    @@ -1617,6 +1617,58 @@ case class InitializeJavaBean(beanInstance: 
Expression, setters: Map[String, Exp
       }
     }
     
    +/**
    + * Initializes an Avro Record instance (that implements the IndexedRecord 
interface) by calling
    + * the `put` method on a the Record instance with the provided position 
and value arguments
    + *
    + * @param objectInstance an expression that will evaluate to the Record 
instance
    + * @param args a sequence of expression pairs that will respectively 
evaluate to the index of
    + *             the record in which to insert, and the argument value to 
insert
    + */
    +case class InitializeAvroObject(
    --- End diff --
    
    Yep, as my comment in 
https://github.com/apache/spark/pull/21348#issuecomment-433631330, AFAIK, maybe 
we can keep 2 pr for convenient review, also there's some refactor work on 
`JavaTypeInference` after #21348, need more advise from Wenchen.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to