Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/22893
  
    Hm, actually that's the best case. You're exercising the case where the 
code path you prefer is fast. And the case where the precision bound applies is 
exactly the case where the branch you deleted helps. As I say, you'd have to 
show this is not impacting other cases significantly, and I think it should. 
Consider the sparse-sparse case.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to