Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22897#discussion_r230130484
  
    --- Diff: 
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStep.scala
 ---
    @@ -47,10 +48,24 @@ private[spark] class BasicDriverFeatureStep(
     
       // Memory settings
       private val driverMemoryMiB = conf.get(DRIVER_MEMORY)
    +
    +  // The memory overhead factor to use. If the user has not set it, then 
use a different
    +  // value for non-JVM apps. This value is propagated to executors.
    +  private val overheadFactor = conf.roleSpecificConf.mainAppResource match 
{
    +    case Some(_: NonJVMResource) =>
    --- End diff --
    
    See above.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to