Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22920#discussion_r230136993
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonBenchmark.scala
---
@@ -86,6 +86,7 @@ object JSONBenchmark extends SqlBasedBenchmark {
spark.read
.schema(schema)
.json(path.getAbsolutePath)
+ .filter((_: Row) => true)
--- End diff --
@MaxGekk . In your PR, you already show the side effect via benchmark .
What I mean is both test cases are meaningful and worth to have. :) And, we
need to compare both results in the future release.
In any way, please create new different benchmark cases for this PR.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
