Github user sujith71955 commented on the issue: https://github.com/apache/spark/pull/22758 Thanks for the comment Sean , there are certain areas which i found inconsistencies, if i get some inputs from experts i think i can update the PR , if we are planning to tackle this issue via other PR then I will close this PR. Currently this issue is causing performance degradation as the node is getting converted to SortMergeJoin even though it has potential to opt Broadcast join as the data size is less than broadcast threshold which triggers unnecessary shuffle. On Fri, 2 Nov 2018 at 12:33 AM, Sean Owen <notificati...@github.com> wrote: > I don't know this code well enough to review. I think there is skepticism > from people who know this code whether this is change is correct and > beneficial. If there's doubt, I think it should be closed. > > â > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/spark/pull/22758#issuecomment-435148158>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/AMZZ-Ws13ku8Nrh7hwpdjDYDY8pOzD-Kks5uq0VzgaJpZM4Xm3l1> > . >
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org