[GitHub] spark pull request #22926: [SPARK-25917][Spark UI] memoryMetrics should be J...

[jianjianjiao]

GitHub user jianjianjiao opened a pull request:

    https://github.com/apache/spark/pull/22926

    [SPARK-25917][Spark UI] memoryMetrics should be Json ignored when being none

    ## What changes were proposed in this pull request?
    
    Spark UI's executors page loads forever when memoryMetrics in None. Fix is 
to JSON ignore memorymetrics when it is None.
    
    ## How was this patch tested?
    
    Before fix: (loads forever)
    
![image](https://user-images.githubusercontent.com/1785565/47875681-64dfe480-ddd4-11e8-8d15-5ed1457bc24f.png)
    
    After fix:
    
    
![image](https://user-images.githubusercontent.com/1785565/47875691-6b6e5c00-ddd4-11e8-9895-db8dd9730ee1.png)
    
    
    That is because code in executorspage.js, Line 268
    exec.memoryMetrics = exec.hasOwnProperty('memoryMetrics') ? 
exec.memoryMetrics : memoryMetrics;


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jianjianjiao/spark 
users/rotang/FixExecutorsPageLoadingForever

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/22926.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #22926
    
----
commit 5826424c931fbba81cc246c3b1afe3f64626e051
Author: Rong Tang <rotang@...>
Date:   2018-11-01T19:37:45Z

    mmemoryMetrics should not json ignored when being none

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org