Github user mgaido91 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22087#discussion_r231107042
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/ml/clustering/BisectingKMeans.scala ---
    @@ -117,7 +117,8 @@ class BisectingKMeansModel private[ml] (
         validateAndTransformSchema(schema)
       }
     
    -  private[clustering] def predict(features: Vector): Int = 
parentModel.predict(features)
    +  @Since("2.4.0")
    --- End diff --
    
    I don't see a good reason either. I think it is fine to expose it.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to