GitHub user MaxGekk opened a pull request: https://github.com/apache/spark/pull/22960
[SPARK-25955][TEST] Porting JSON tests for CSV functions ## What changes were proposed in this pull request? In the PR, I propose to port existing JSON tests from `JsonFunctionsSuite` that are applicable for CSV, and put them to `CsvFunctionsSuite`. In particular: - roundtrip `from_csv` to `to_csv`, and `to_csv` to `from_csv` - using `schema_of_csv` in `from_csv` - Java API `from_csv` - using `from_csv` and `to_csv` in exprs. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MaxGekk/spark-1 csv-additional-tests Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/22960.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #22960 ---- commit 345f2a6b0d480a6e24a398380a49792366fa8c6e Author: Maxim Gekk <max.gekk@...> Date: 2018-11-06T19:36:34Z Tests - roundtrip from_csv <-> to_csv commit 606be67e8a422a0e650c2dc29bd724be9b80e411 Author: Maxim Gekk <max.gekk@...> Date: 2018-11-06T20:07:44Z SQL + java tests ---- --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org