Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22943#discussion_r231382309
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala
---
@@ -140,16 +140,10 @@ class DateTimeUtilsSuite extends SparkFunSuite {
c = Calendar.getInstance()
c.set(2015, 2, 18, 0, 0, 0)
c.set(Calendar.MILLISECOND, 0)
- assert(stringToDate(UTF8String.fromString("2015-03-18")).get ===
- millisToDays(c.getTimeInMillis))
- assert(stringToDate(UTF8String.fromString("2015-03-18 ")).get ===
- millisToDays(c.getTimeInMillis))
- assert(stringToDate(UTF8String.fromString("2015-03-18 123142")).get ===
- millisToDays(c.getTimeInMillis))
- assert(stringToDate(UTF8String.fromString("2015-03-18T123123")).get ===
- millisToDays(c.getTimeInMillis))
- assert(stringToDate(UTF8String.fromString("2015-03-18T")).get ===
- millisToDays(c.getTimeInMillis))
+ Seq("2015-03-18", "2015-03-18 ", " 2015-03-18", " 2015-03-18 ",
"2015-03-18 123142",
--- End diff --
ah i see
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
