Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/22087 ah, good point @imatiach-msft , I missed the `HasLabelCol` in `PredictorParams`. We might have to revise the trait hierarchy here to something like you mentioned. I do agree with @srowen to escalate this, and I'd also suggest to create a design doc for the new hierarchy, so that it can be reviewed more carefully and by a broader audience
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org