Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22977#discussion_r231936644
  
    --- Diff: project/MimaExcludes.scala ---
    @@ -84,7 +84,17 @@ object MimaExcludes {
         
ProblemFilters.exclude[IncompatibleMethTypeProblem]("org.apache.spark.streaming.api.java.JavaPairDStream.flatMapValues"),
         // [SPARK-25680] SQL execution listener shouldn't happen on execution 
thread
         
ProblemFilters.exclude[IncompatibleResultTypeProblem]("org.apache.spark.sql.util.ExecutionListenerManager.clone"),
    -    
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.sql.util.ExecutionListenerManager.this")
    +    
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.sql.util.ExecutionListenerManager.this"),
    +    // [SPARK-25862][SQL] Remove rangeBetween APIs introduced in 
SPARK-21608
    +    
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.sql.functions.unboundedFollowing"),
    +    
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.sql.functions.unboundedPreceding"),
    +    
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.sql.functions.currentRow"),
    +    
ProblemFilters.exclude[IncompatibleMethTypeProblem]("org.apache.spark.sql.expressions.Window.rangeBetween"),
    +    
ProblemFilters.exclude[IncompatibleMethTypeProblem]("org.apache.spark.sql.expressions.WindowSpec.rangeBetween"),
    +    // [SPARK-23781][CORE] Merge token renewer functionality into 
HadoopDelegationTokenManager
    +    
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.deploy.SparkHadoopUtil.nextCredentialRenewalTime"),
    --- End diff --
    
    It was a `private[spark]` method which has to be implemented as a public 
method in the Java bytecode. MiMa doesn't know the difference. Yes it can be 
ignore for sure.
    
    So these failures are 'new' because they were introduced after Spark 2.2 
(hence not missing since 2.2) then removed, so bumping the previous version 
causes them to fail now? OK.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to