Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/22989
cc all reviewer, as @srowen's suggestion, add a rule to ban all of new
Error cases.
List currently `throw new XXXError` in Spark source below and record fix up
or exclude for review conveniently:
ErrorName | Count | In Test/Source Code | Fix Up or Exclude
------------ | ------------- | ------------- | -------------
AssertionError | 32 | 29 in test code | Exclude
| | | 2 in UnsafeAlignedOffset | Fix up by changing them to
`IllegalArgumentException`
| | | 1 in KafkaUtils | Just exclude cause fix it will cause behavior change
NotImplementedError | 22 | 7 in source code/ 15 in test cases | Fix up by
changing them to `UnsupportedOperationException`
OutOfMemoryError | 1 | 1 in test code | Exclude
LinkageError | 1 | 1 in test code | Exclude
SparkOutOfMemoryError | 5 | 5 in source code | Exclude
UnknownError | 9 | 5 in source code/ 4 in test cases | Fix up by changing
to `IllegalAccessException ` and `IllegalArgumentException`
All above done in 6e49bb8.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
