Github user srowen commented on the issue: https://github.com/apache/spark/pull/22989 `AssertionError` in tests is wrong. It should really just call `fail()`. If you're willing to fix that, it would be a great cleanup. The `AssertionError` in UnsafeAlignedOffset is legitimate and can be excluded. I would fix the `AssertionError` in KafkaUtils. That one is clearly an illegal argument check. Agree about the rest. Thanks for the great analysis @xuanyuanking
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org