Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/23022#discussion_r233069204 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/types/DecimalSuite.scala --- @@ -228,4 +228,10 @@ class DecimalSuite extends SparkFunSuite with PrivateMethodTester { val decimal = Decimal.apply(bigInt) assert(decimal.toJavaBigDecimal.unscaledValue.toString === "9223372036854775808") } + + test("SPARK-26038: toScalaBigInt/toJavaBigInteger not fitting long") { --- End diff -- Should we test the branch when `decimalVal.ne(null)` is `true`?
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org