Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23049#discussion_r234003620
--- Diff: bin/load-spark-env.sh ---
@@ -42,19 +42,20 @@ fi
# Setting SPARK_SCALA_VERSION if not already set.
if [ -z "$SPARK_SCALA_VERSION" ]; then
-
- ASSEMBLY_DIR2="${SPARK_HOME}/assembly/target/scala-2.11"
- ASSEMBLY_DIR1="${SPARK_HOME}/assembly/target/scala-2.12"
-
- if [[ -d "$ASSEMBLY_DIR2" && -d "$ASSEMBLY_DIR1" ]]; then
- echo -e "Presence of build for multiple Scala versions detected." 1>&2
- echo -e 'Either clean one of them or, export SPARK_SCALA_VERSION in
spark-env.sh.' 1>&2
+ SCALA_VERSION1=2.12
+ SCALA_VERSION2=2.11
+
+ ASSEMBLY_DIR1="${SPARK_HOME}/assembly/target/scala-${SCALA_VERSION1}"
+ ASSEMBLY_DIR2="${SPARK_HOME}/assembly/target/scala-${SCALA_VERSION2}"
+ if [[ -d "$ASSEMBLY_DIR1" && -d "$ASSEMBLY_DIR2" ]]; then
+ echo -e "Presence of build for multiple Scala versions
detected($ASSEMBLY_DIR1 and $ASSEMBLY_DIR2)." 1>&2
--- End diff --
Nit: space after 'detected'. I think you can put this in one string if you
like.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
