Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23045#discussion_r234037904
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/TypeUtils.scala
---
@@ -46,12 +46,20 @@ object TypeUtils {
if (TypeCoercion.haveSameType(types)) {
TypeCheckResult.TypeCheckSuccess
} else {
- return TypeCheckResult.TypeCheckFailure(
+ TypeCheckResult.TypeCheckFailure(
s"input to $caller should all be the same type, but it's " +
types.map(_.catalogString).mkString("[", ", ", "]"))
}
}
+ def checkForMapKeyType(keyType: DataType): TypeCheckResult = {
+ if (keyType.existsRecursively(_.isInstanceOf[MapType])) {
+ TypeCheckResult.TypeCheckFailure("The key of map cannot be/contains
map.")
--- End diff --
nit. `contains` -> `contain`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
