Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23065#discussion_r234393755
--- Diff:
external/kinesis-asl/src/test/java/org/apache/spark/streaming/kinesis/JavaKinesisInputDStreamBuilderSuite.java
---
@@ -49,13 +51,14 @@ public void testJavaKinesisDStreamBuilder() {
.checkpointInterval(checkpointInterval)
.storageLevel(storageLevel)
.build();
- assert(kinesisDStream.streamName() == streamName);
- assert(kinesisDStream.endpointUrl() == endpointUrl);
- assert(kinesisDStream.regionName() == region);
- assert(kinesisDStream.initialPosition().getPosition() ==
initialPosition.getPosition());
- assert(kinesisDStream.checkpointAppName() == appName);
- assert(kinesisDStream.checkpointInterval() == checkpointInterval);
- assert(kinesisDStream._storageLevel() == storageLevel);
+ Assert.assertEquals(streamName, kinesisDStream.streamName());
--- End diff --
These assertions were wrong in two ways: == and assert
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
