Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23093#discussion_r235019790
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala
---
@@ -91,7 +91,7 @@ class DecisionTreeClassifier @Since("1.4.0") (
/** @group setParam */
@Since("1.4.0")
- override def setImpurity(value: String): this.type = set(impurity, value)
+ def setImpurity(value: String): this.type = set(impurity, value)
--- End diff --
OK I think I'm wrong about the logic, given the first attempt to do this in
https://github.com/apache/spark/pull/17867 Yes this is fine. In fact I think
you're welcome to just revive that PR and remove a lot of similar deprecated
methods again.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
