Github user abehm commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23096#discussion_r235146495
  
    --- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisTest.scala
 ---
    @@ -54,7 +54,7 @@ trait AnalysisTest extends PlanTest {
           expectedPlan: LogicalPlan,
           caseSensitive: Boolean = true): Unit = {
         val analyzer = getAnalyzer(caseSensitive)
    -    val actualPlan = analyzer.executeAndCheck(inputPlan)
    +    val actualPlan = analyzer.executeAndCheck(inputPlan, None)
    --- End diff --
    
    This interface change might invite conflicts with OSS when new tests are 
added? Have you considered alternatives that do not require such a change?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to