Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/23080#discussion_r235589426
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/CSVOptions.scala
---
@@ -216,8 +232,13 @@ class CSVOptions(
format.setDelimiter(delimiter)
format.setQuote(quote)
format.setQuoteEscape(escape)
+ lineSeparator.foreach {sep =>
+ format.setLineSeparator(sep)
+ format.setNormalizedNewline(0x00.toChar)
--- End diff --
I know we have some problems here for setting newlines more then 1
character because `setNormalizedNewline` only supports one character.
This is related with
https://github.com/apache/spark/pull/18581#issuecomment-314037750 and
https://github.com/uniVocity/univocity-parsers/issues/170
That's why I thought we can only support this for single character for now.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
