Github user manishamde commented on a diff in the pull request:
https://github.com/apache/spark/pull/3374#discussion_r20628996
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/GradientBoostedTrees.scala ---
@@ -45,146 +43,92 @@ import org.apache.spark.storage.StorageLevel
* but weak hypothesis weights are not computed correctly for LogLoss
or AbsoluteError.
--- End diff --
@jkbradley Agree. Having said that, I am not sure whether the algorithm
predictions are changed or not based upon the loss function in other weak
learners such as LR. Let's refine this later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
