Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23100#discussion_r236097295
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/ml/feature/OneHotEncoder.scala ---
    @@ -17,126 +17,512 @@
     
     package org.apache.spark.ml.feature
     
    +import org.apache.hadoop.fs.Path
    --- End diff --
    
    The changes here are basically the copy-paste from OneHotEncoderEstimator? 
I wonder if we could structure this as a delete, followed by move, in git, for 
a better history. But, doesn't matter much or maybe it's treated the same.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to