Github user juliuszsompolski commented on the issue:

    https://github.com/apache/spark/pull/23127
  
    @cloud-fan @rednaxelafx
    Actually, the input to a codegen stage can be an internal row so I can't 
make the inputRDD be `RDD[UnsafeRow], but the output needs to be UnsafeRow.
    Doing it like `InputAdapter` did actually make it just pass-through output 
the internal row.
    For `InputAdapter`, there always is some parent operator to consume it, and 
create an unsafe projection in whatever it does, and then the output UnsafeRows.
    But for an `RDDScanExec` or `RowDataSourceScanExec` could be alone in a 
WholeStageCodegenExec, and then just doing `${consume(ctx, null, row)}` made it 
pass-through output the InternalRow from input.
    
    WDYT about how I patched it up?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to