Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/3009#discussion_r20665632
--- Diff:
core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala ---
@@ -144,11 +146,30 @@ class JobProgressListener(conf: SparkConf) extends
SparkListener with Logging {
}
override def onJobStart(jobStart: SparkListenerJobStart) = synchronized {
- val jobGroup =
Option(jobStart.properties).map(_.getProperty(SparkContext.SPARK_JOB_GROUP_ID))
+ val jobGroup = for (
+ props <- Option(jobStart.properties);
+ group <- Option(props.getProperty(SparkContext.SPARK_JOB_GROUP_ID))
+ ) yield group
val jobData: JobUIData =
- new JobUIData(jobStart.jobId, jobStart.stageIds, jobGroup,
JobExecutionStatus.RUNNING)
+ new JobUIData(jobStart.jobId, Some(System.currentTimeMillis), None,
jobStart.stageIds,
--- End diff --
Can you name each of these parameters? As is, I find it hard to read
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
