Github user markpavey commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23102#discussion_r236343483
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/DependencyUtils.scala 
---
    @@ -61,11 +61,13 @@ private[deploy] object DependencyUtils extends Logging {
           hadoopConf: Configuration,
           secMgr: SecurityManager): String = {
         val targetDir = Utils.createTempDir()
    +    val fileSeparator = Pattern.quote(File.separator)
    --- End diff --
    
    The Java String.split method treats its parameter as a regular expression. 
The File.separator is a single backslash '\' it throws a 
PatternSyntaxException. Wrapping it in Pattern.quote ensures it is interpreted 
as a literal value.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to