Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/23088#discussion_r236398604
--- Diff:
core/src/test/scala/org/apache/spark/status/AppStatusStoreSuite.scala ---
@@ -95,10 +123,18 @@ class AppStatusStoreSuite extends SparkFunSuite {
private def newTaskData(i: Int): TaskDataWrapper = {
new TaskDataWrapper(
- i, i, i, i, i, i, i.toString, i.toString, i.toString, i.toString,
false, Nil, None,
+ i, i, i, i, i, i, i.toString, i.toString, "SUCCESS", i.toString,
false, Nil, None,
i, i, i, i, i, i, i, i, i, i,
i, i, i, i, i, i, i, i, i, i,
i, i, i, i, stageId, attemptId)
}
+ private def failedTaskData(i: Int): TaskDataWrapper = {
--- End diff --
better to have the status be a parameter to the existing method (with a
default value)
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
