Github user bkrieger commented on a diff in the pull request: https://github.com/apache/spark/pull/22995#discussion_r236724749 --- Diff: core/src/main/scala/org/apache/spark/broadcast/TorrentBroadcast.scala --- @@ -92,8 +95,15 @@ private[spark] class TorrentBroadcast[T: ClassTag](obj: T, id: Long) /** The checksum for all the blocks. */ private var checksums: Array[Int] = _ - override protected def getValue() = { - _value + override protected def getValue() = synchronized { --- End diff -- Do you mean switching `TorrentBroadcast.synchronized` to `broadcastCache.synchronized` inside `readBroadcastBlock`, or changing `this.synchronized` to `broadcastCache.synchronized` inside `getValue()` (and getting rid of the lock in `readBroadcastBlock`?
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org