Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23098#discussion_r236726267
--- Diff: dev/create-release/release-build.sh ---
@@ -110,16 +110,18 @@ fi
# Depending on the version being built, certain extra profiles need to be
activated, and
# different versions of Scala are supported.
BASE_PROFILES="-Pmesos -Pyarn"
-PUBLISH_SCALA_2_10=0
-SCALA_2_10_PROFILES="-Pscala-2.10"
-SCALA_2_11_PROFILES=
+
+# TODO: revisit for Scala 2.13
+
+PUBLISH_SCALA_2_11=1
--- End diff --
Just a question though, if you're releasing 2.3 wouldn't you use the
release script as of 2.3?
I think the script works for Spark 1.6 and 2.x, but not earlier versions,
already. What about drawing the lines at major releases, so that this can
simplify further?
Right now I think it's basically trying to support 2.2+, which are the
non-EOL releases, which seems reasonable?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
