Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22612#discussion_r236860104
--- Diff:
core/src/main/scala/org/apache/spark/metrics/ExecutorMetricType.scala ---
@@ -95,10 +136,22 @@ private[spark] object ExecutorMetricType {
OnHeapUnifiedMemory,
OffHeapUnifiedMemory,
DirectPoolMemory,
- MappedPoolMemory
+ MappedPoolMemory,
+ ProcessTreeMetrics
)
- // Map of executor metric type to its index in values.
- val metricIdxMap =
- Map[ExecutorMetricType, Int](ExecutorMetricType.values.zipWithIndex:
_*)
+
+ val (metricToOffset, numMetrics) = {
+ var numberOfMetrics = 0
+ val definedMetricsAndOffset = mutable.LinkedHashMap.empty[String, Int]
+ metricGetters.foreach { m =>
+ var metricInSet = 0
+ while (metricInSet < m.names.length) {
+ definedMetricsAndOffset += (m.names(metricInSet) -> (metricInSet +
numberOfMetrics))
+ metricInSet += 1
+ }
--- End diff --
```scala
(0 until m.names.length).foreach { idx =>
definedMetricsAndOffset += (m.names(idx) -> (idx + numberOfMetrics)
}
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
