Github user heary-cao commented on a diff in the pull request:
https://github.com/apache/spark/pull/23151#discussion_r236919725
--- Diff: core/src/test/scala/org/apache/spark/SparkFunSuite.scala ---
@@ -105,5 +105,16 @@ abstract class SparkFunSuite
logInfo(s"\n\n===== FINISHED $shortSuiteName: '$testName' =====\n")
}
}
-
+ /**
+ * Creates a temporary directory, which is then passed to `f` and will
be deleted after `f`
+ * returns.
+ *
+ * @todo Probably this method should be moved to a more general place
+ */
+ protected def withCreateTempDir(f: File => Unit): Unit = {
+ val dir = Utils.createTempDir()
--- End diff --
I'm not sure if I need call `.getCanonicalFile` again. i feel it's a little
redundant. review `Utils.createTempDir()` --> `createDirectory` -->
`dir.getCanonicalFile`.
It has been called `.getCanonicalFile`. thanks.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
