Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/spark/pull/23169#discussion_r237304214
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/SizeLimitedWriter.scala
---
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.catalyst.util
+
+import java.io.Writer
+
+class WriterSizeException(val attemptedSize: Long, val charLimit: Long)
extends Exception(
+ s"Attempted to write $attemptedSize characters to a writer that is
limited to $charLimit")
+
+/**
+ * This class is used to control the size of generated writers.
Guarantees that the total number
+ * of characters written will be less than the specified size.
+ *
+ * Checks size before writing and throws a WriterSizeException if the
total size would count the
+ * limit.
+ */
+class SizeLimitedWriter(underlying: Writer, charLimit: Long) extends
Writer {
+
+ var charsWritten: Long = 0
+
+ override def write(cbuf: Array[Char], off: Int, len: Int): Unit = {
--- End diff --
I'd rather make this writing the content as much as possible (with `...`),
or let WriterSizeException contains relevant information to help caller be able
to call this again with smaller length.
In worst case, if first physical plan is huge we end up only showing `...`.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
