Github user sujithjay commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22806#discussion_r237447252
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
    @@ -1091,6 +1091,10 @@ private[spark] class TaskSetManager(
       def executorAdded() {
         recomputeLocality()
       }
    +
    +  def markPartitionIdAsCompletedForTaskAttempt(index: Int): Unit = {
    +    successful(index) = true
    --- End diff --
    
    Should this method also make a call to 
`TaskSetManager.maybeFinishTaskSet()`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to