Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/23151#discussion_r237617706
--- Diff:
core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala ---
@@ -494,13 +494,12 @@ class SparkSubmitSuite
}
test("launch simple application with spark-submit with redaction") {
- val testDir = Utils.createTempDir()
- testDir.deleteOnExit()
- val testDirPath = new Path(testDir.getAbsolutePath())
val unusedJar = TestUtils.createJarWithClasses(Seq.empty)
val fileSystem = Utils.getHadoopFileSystem("/",
SparkHadoopUtil.get.newConfiguration(new SparkConf()))
- try {
+ withTempDir { testDir =>
+ testDir.deleteOnExit()
--- End diff --
`deleteOnExit` is redundant for directories created by
`Utils.createTempDir`. That method already tracks directories to cleanup on
exit.
(Also `deleteOnExit` does not work for non-empty directories.)
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
